Skip to content

Sentinel-1 VV VH backscatter DA (REWORKED)#1415

Open
cmclaug2 wants to merge 6 commits intoNASA-LIS:masterfrom
cmclaug2:Sentinel1_DA_for_PR
Open

Sentinel-1 VV VH backscatter DA (REWORKED)#1415
cmclaug2 wants to merge 6 commits intoNASA-LIS:masterfrom
cmclaug2:Sentinel1_DA_for_PR

Conversation

@cmclaug2
Copy link
Contributor

@cmclaug2 cmclaug2 commented Sep 20, 2023

Description

This PR is a reworked version of #1208
This PR:

  • Extracts the testcase that was added to the source code
  • Updates documentation
  • Reverts Config.pl to the Main branch
  • Removes unnecessary NaN check in LIS_historyMod.F90

Addresses #1192
Addresses #1012

Testcase

I have confirmed this replicates the testcase in #1208
I have confirmed this compiles with strict checks.

mbechtold and others added 6 commits August 24, 2022 15:53
@mbechtold
ENH: Feature Water Clould Model added to RTMs
2e47ce5
@mbechtold @cmclaug2
S1 backscatter DA functionality added
34ed98b
@mbechtold @cmclaug2
Merge branch 'master' into Sentinel1_DA_for_PR
0977439
@cmclaug2
Clean up
dcf8287 
+ Updates documentation
+ Undos the changes made by KUL to Config.pl
+ Removed unneeded check for NaNs in LIS_historyMod.F90
@cmclaug2
Merge branch 'NASA-LIS:master' into Sentinel1_DA_for_PR
9c63a9a
@cmclaug2
Use Config.pl from Main branch
a845eb8 
The prior commit did not use Config.pl from the Main branch.
This was referenced Sep 20, 2023
Open
Open
@KUL-RSDA KUL-RSDA mentioned this pull request Sep 22, 2023
Open
@jvgeiger
Copy link
Contributor

jvgeiger commented Oct 12, 2023

When compiled with GNU compilers, LIS crashes in enkf_Mod.F90 at line 319 with the message:

Error in `./LIS': malloc(): memory corruption:

When compiled with Intel compilers with additional debugging enabled, LIS crashes in LIS_DAobservationsMod.F90 at line 2051 with the message:

forrtl: severe (408): fort: (3): Subscript #2 of the array LIS_OBS_NGRIDS has value -1 which is less than the lower bound of 0

In S1_sigmaVVVHSMLAI/S1_sigmaVVVHSMLAI_Mod.F90, flist is used uninitialized. This file also uses ls to create a list of files. This should be replaced with a call to create_filelist.

@jvgeiger jvgeiger self-assigned this Oct 12, 2023
jvgeiger added a commit to KathyNie/LISF that referenced this pull request Dec 8, 2023
@jvgeiger
Add bug fix for latlon projection
8d8c84c 
This bug fix is from Michel Bechtold and Samuel Scherrer.  See PR NASA-LIS#1415.
@mbechtold mbechtold mentioned this pull request Feb 21, 2024
Open
@mbechtold
Copy link
Contributor

mbechtold commented Feb 21, 2024

Hi @jvgeiger
I addressed the issues that you raised in this PR cmclaug2#1 for the branch of @cmclaug2. Results are zero-diff.
The only thing I could not test is the compilation with the GNU compiler. Hope the memory corruption is fixed as well. Let me know if there is anything else I can do to finalize this PR.
Thanks!

@mbechtold
Copy link
Contributor

mbechtold commented Sep 27, 2024

@dmocko @sujayvkumar @cmclaug2 @jvgeiger
In February, I added this note to the PR. Would be great if this PR could eventually be merged soon to make this DA instance easily accessible for other LIS users.

@jvgeiger
Copy link
Contributor

jvgeiger commented Oct 15, 2024

Hello. I apologize for the delay. We get to pull requests, issues, and discussions when time permits. Unfortunately, other tasks kept coming up. I will review your bug fixes and finish this pull request as soon as possible.

jvgeiger added a commit to jvgeiger/LISF that referenced this pull request May 30, 2025
@jvgeiger
Add bug fix for latlon projection
1156692 
This bug fix is from Michel Bechtold and Samuel Scherrer.  See PR NASA-LIS#1415.

(cherry picked from commit 8d8c84c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jvgeiger jvgeiger

Labels

NotReady

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmclaug2 @jvgeiger @mbechtold